Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localization #6349

Closed
wants to merge 5 commits into from
Closed

Localization #6349

wants to merge 5 commits into from

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Oct 17, 2023 •
edited
Loading

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@dafeda
Temporarily add flow_config.yml to enable running with flow
4180da7
@dafeda
Implement adaptive localization
d80f169 
Add option of running adaptive localization that can simply
be turned on and does not need any user input.
Only parameters that are significantly correlated to responses
will be updated.
Default value of what constitutes significant correlation is calculated
based on theory, but can be set by the user.
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023 •
edited
Loading

Codecov Report

Merging #6349 (c8fa508) into main (f9f34a1) will increase coverage by 1.16%.
Report is 3 commits behind head on main.
The diff coverage is 89.53%.

@@            Coverage Diff             @@
##             main    #6349      +/-   ##
==========================================
+ Coverage   82.64%   83.81%   +1.16%     
==========================================
  Files         347      342       -5     
  Lines       21390    20810     -580     
  Branches      862      856       -6     
==========================================
- Hits        17678    17442     -236     
+ Misses       3413     3073     -340     
+ Partials      299      295       -4
Files Coverage Δ
...ert/gui/ertwidgets/analysismodulevariablespanel.py 84.82% <100.00%> (+5.97%) ⬆️
src/ert/analysis/_es_update.py 89.53% <93.02%> (+0.53%) ⬆️
src/ert/config/analysis_module.py 86.55% <82.85%> (-2.92%) ⬇️

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dafeda dafeda self-assigned this Oct 17, 2023
@dafeda dafeda added the release-notes:new-feature Automatically categorise as new feature in release notes label Oct 17, 2023
dafeda
dafeda commented Oct 17, 2023
View reviewed changes
tests/unit_tests/cli/test_integration_cli.py
@@ -78,6 +78,20 @@ def test_runpath_file(tmpdir, source_root):
assert os.path.isfile("RUNPATH_WORKFLOW_1.OK")


# def test_reek_case():
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to delete this and other test-files before merging.

@dafeda dafeda closed this Oct 18, 2023
@kvashchuka kvashchuka deleted the localization branch December 19, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dafeda dafeda

Labels
release-notes:new-feature Automatically categorise as new feature in release notes
Projects
SCOUT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dafeda @codecov-commenter @kvashchuka @Blunde1